GH-130396: Include stack margin for debug windows builds#130554
Merged
markshannon merged 1 commit intopython:mainfrom Feb 25, 2025
Merged
GH-130396: Include stack margin for debug windows builds#130554markshannon merged 1 commit intopython:mainfrom
markshannon merged 1 commit intopython:mainfrom
Conversation
markshannon
changed the title
brandtbucher
approved these changes
Feb 25, 2025
Member
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
Seems good! Should we run the buildbot it broke?
Member
Author
|
Actually, its a CI job: https://github.com/python/cpython/actions/runs/13527121766/job/37803109505?pr=130550 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might only be necessary on Windows debug free-threading builds, but it is simpler and harmless to do this for any Windows debug build.